Fix handle max size limitation#5
Conversation
legalsylvain
force-pushed
the
FIX-handle-max-size-limitation
branch
from
a3aacf0 to
791f871
Compare
legalsylvain
force-pushed
the
FIX-handle-max-size-limitation
branch
2 times, most recently
from
b9a64d5 to
088560b
Compare
|
|
||
| new_labels = set() | ||
| for modified_addon in modified_addons: | ||
| label_name = f"addons:{modified_addon}" |
There was a problem hiding this comment.
| label_name = f"addons:{modified_addon}" | |
| label_name = f"addon:{modified_addon}" |
Without s. Maybe we could even shortent it a bit more (ad: ? mod:) ?
Can you factor out the function that computes the shortened label?
There was a problem hiding this comment.
There was a problem hiding this comment.
- added new config
MODULE_LABEL_COLOR
legalsylvain
force-pushed
the
FIX-handle-max-size-limitation
branch
from
88887c7 to
2f29361
Compare
|
I'll update the cassette. Can you add a couple of unit tests for |
legalsylvain
force-pushed
the
FIX-handle-max-size-limitation
branch
from
2f29361 to
4257aca
Compare
if label name is too long, it is cut, and ended by an hash of the module name. the module name is present in the description of the label - factor out function that computes the shortened label - use 'mod:' instead of 'addon:' - add MODULE_LABEL_COLOR as new configuration Co-authored-by: Stéphane Bidoul <stephane.bidoul@acsone.eu>
legalsylvain
force-pushed
the
FIX-handle-max-size-limitation
branch
from
73c06aa to
fca5c9d
Compare
|
Hi @sbidoul : done (except cassette change to do) General remark on this new feature : The current implementation tag PR that are changing any module files (and related files in setup). I'd like to add an argument (exclude_autogenerated_files = False) in the function I mean, as a maintainer of the module, I don't care to have the PR that are only changing autogenerated file in one of "my" module. (index.html, main README.rst, toml, etc...). if a PR apply index template changes (like the OCA banner), it will tag all modules. that is not necessary (and wrong in my opinion), as there are "technical PR". WDYT ? (not a blocking point, a nice to have IMO) In fact, if this option is added, I'd like to enable it also for the "mention maintainer" feature. |
|
It probably makes sense to exclude some PRs from various bot actions. Maybe open another issue about that? |
2 participants
No description provided.